Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to BlueStyle #141

Closed
oxinabox opened this issue Dec 24, 2019 · 3 comments · Fixed by #165
Closed

Change to BlueStyle #141

oxinabox opened this issue Dec 24, 2019 · 3 comments · Fixed by #165

Comments

@oxinabox
Copy link
Member

Talked to @jrevels about this a few months back. And he wasfine with it.
Right now the code is roughly in the intersection of what YASGuide and BlueStyle allow.
Which is pretty large as they overlap significantly.

But given most people maintaining it now are used to BlueStyle, we should use that.

#80 doesn't follow BlueStyle indenting.
And that's fine because the readme says YASGuide.
But we should change that

@YingboMa
Copy link
Member

I feel like that the BlueStyle is overly restrictive. For instance, I don't see much benefit from sorting imports logically, but it adds a huge burden to developers. I'd vote for stick with the YASGuide.

@mattBrzezinski
Copy link
Member

It takes about a minute to sort imports alphabetically, and then makes it much easier for anyone to quickly find if a package has been introduced already.

I'm not following along much with this package, or either style guides. But I believe doing small changes like this makes the package seem more put together and professional.

I think little things like this make for a good use case for a Julia linter, and other small tools to help simplify things.

@YingboMa
Copy link
Member

You could just search in Project.toml for packages. I don't see how sorting it helps anyone, especially, for stuff like

using Dates: Year, Month, Week, Day, Hour, Minute, Second, Millisecond

I don't know about Atom, but it is so hard to get those tools to work with Vim or VSCode. If there is a simple way to do it, I will be fine with it. But I feel it adds unnecessary steps and mental effort to do something with little gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants