New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU tests don't test anything #307

Open

gdalle opened this issue Oct 7, 2024 · 1 comment

Member

gdalle commented Oct 7, 2024

I don't think the tests in https://github.com/JuliaDiff/SparseDiffTools.jl/blob/master/test/test_gpu_ad.jl verify correctness of the Jacobian, it's only about whether or not the code runs. Since #302 breaks GPU tests, it means the code path with the wrong indexing was taken by GPUs, so GPU Jacobians have probably been wrong all along.

gdalle mentioned this issue

Fix default rows_index and cols_index in Jacobian #302

Open

Member

ChrisRackauckas commented Oct 7, 2024

There are SciMLSensitivity/DiffEqFlux downstream tests that would've required its accuracy.

gdalle mentioned this issue

Add direct Enzyme support SciML/NonlinearSolve.jl#476

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment