Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispatch for remove_all_from_space! #1105

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

simsurace
Copy link
Contributor

This fixes #1104.

  • Restrict the method in discrete.jl to discrete spaces
  • Add a test that defines a new space as described in the dev docs and checks that adding and removing agents works. The test fails without the next step
  • Add a generic fallback that makes the new test pass
  • Add a note in the dev docs that this is a candidate to be overloaded for performance

@Tortar
Copy link
Member

Tortar commented Nov 16, 2024

Cool, thank you, unfortunately tests are broken on 1.11.1, but I suppose they run locally, right? Can you bump the version so that we release it right away?

@simsurace
Copy link
Contributor Author

They do pass on 1.10 locally. I don't understand the failure on 1.11 unfortunately. I'll bump.

@Tortar Tortar merged commit be40fb0 into JuliaDynamics:main Nov 16, 2024
2 of 5 checks passed
@Tortar
Copy link
Member

Tortar commented Nov 17, 2024

sorry, thought you had bumped :Q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type signature in remove_all_from_space! method for discrete space?
2 participants