Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable manual assignment of ID in version 6. #861

Closed
Datseris opened this issue Aug 27, 2023 · 3 comments
Closed

Disable manual assignment of ID in version 6. #861

Datseris opened this issue Aug 27, 2023 · 3 comments
Labels
agent-construction About making agents breaking multi-agent Related with multi-agent models

Comments

@Datseris
Copy link
Member

Datseris commented Aug 27, 2023 •
edited
Loading

Since we are going to a breaking 6.0 release due to the continuous space SVector change, we might as well ensure that there is no way for the user to manually add id to agents. cc @Tortar and discussions in #445 and #841
@Datseris
Copy link
Member Author

This means we need to deprecate the add_agent!(a::Agent, ....) function, as this is the only way to add user-created agents ot the model. Otherwise add_agent!(model, ...) does the trick.

@Datseris Datseris added agent-construction About making agents multi-agent Related with multi-agent models labels Aug 27, 2023
@Tortar
Copy link
Member

Tortar commented Aug 27, 2023

I think this would be best! More we have control of the fields used internally the better

This was referenced Sep 8, 2023
Merged
Closed
@Tortar
Copy link
Member

Tortar commented Sep 8, 2023

Implemented in #871

@Tortar Tortar closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-construction About making agents breaking multi-agent Related with multi-agent models
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Datseris @Tortar