Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wrappers for CUDA v12.6.1 #2499

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Update wrappers for CUDA v12.6.1 #2499

merged 3 commits into from
Sep 19, 2024

Conversation

amontoison
Copy link
Member

No description provided.

@maleadt
Copy link
Member

maleadt commented Sep 18, 2024

Huh, I didn't expect header changes in a patch update.

@maleadt
Copy link
Member

maleadt commented Sep 18, 2024

#2461 (comment)

@amontoison
Copy link
Member Author

amontoison commented Sep 18, 2024 •
edited
Loading

CUDA.jl/lib/complex.jl

Line 1 in cab8f2d

# CUDA's complex types are defined in terms of vector types (float2, double2),

Documentation of the routine here.
I will update the toml file.

@maleadt
Copy link
Member

maleadt commented Sep 19, 2024

CUDA's complex types are defined in terms of vector types (float2, double2),

I know, but our wrapper generator doesn't emit such code. The fact that I had to manually edit is what I was hinting at.

Anyway, LGTM, CUDNN failure unrelated. Thanks for the PR!

@maleadt maleadt merged commit da66df1 into JuliaGPU:master Sep 19, 2024
1 check failed
@amontoison amontoison deleted the wrappers branch September 25, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @maleadt