Table to FeatureCollection #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
approved these changes
Dec 30, 2022
| df = DataFrame(GeoJSON.FeatureCollection(features)) | ||
| @test df == DataFrame(GeoJSON.FeatureCollection(df)) | ||
|
|
||
| df_custom_col = DataFrame(:points => [p, p], :x => [1, 2]) |
There was a problem hiding this comment.
Does it work with other non-GeoJSON.jl geometry types as well?
There was a problem hiding this comment.
Good question! I actually forgot about that. So we need the other convert PR merged first.
I'll get that passing and come back to this. It's also a good example of how the traittype method will be useful from within a package as well.
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
|
Arrg I really stalled on this, just ran into it again... but I guess it has to wait for the @evetion PR. |
|
This is also not really worth having if we instead have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Tables.jl handler to the FeatureCollection constructor. This implementation is likely not very performant, but it works for now.
Closes #55