Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflowError on plots of large sequences #221

Closed
gabuzi opened this issue Nov 17, 2023 · 1 comment · Fixed by #220
Closed

StackOverflowError on plots of large sequences #221

gabuzi opened this issue Nov 17, 2023 · 1 comment · Fixed by #220

Comments

@gabuzi
Copy link
Contributor

gabuzi commented Nov 17, 2023

Hi,
I went a bit more in-depth with Koma and depart from the examples. Trying to import some of our sequences that we use on daily basis seems to cause errors in the plots on my system.

pulseq files were generated with pypulseq and the sequences are small scaled-down examples of what we use (2D Cartesian with 64 phase encode steps and 18 repetitions per step).

Sequence was read with

julia> using KomaMRI

julia> seq = read_seq("/path/to/seqfile")
Sequence[ τ = 39276.8 ms | blocks: 6912 | ADC: 1152 | GR: 5724 | RF: 1088 | DEF: 9 ]
julia> plot_seq(seq)
ERROR: StackOverflowError:

I used v0.7.5 with julia 1.9.1 on macOS and Ubuntu (same behavior).

I opened #220 that addresses this, but it's probably better to have an issue for it as well to give more context.

@cncastillo
Copy link
Member

cncastillo commented Nov 17, 2023

Thanks @gabuzi :) Running the CI on the pull

If it passes all the tests, it will be an instant merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants