Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluto fat sat low field #304

Closed
wants to merge 7 commits into from
Closed

Pluto fat sat low field #304

wants to merge 7 commits into from

Conversation

beorostica
Copy link
Contributor

This pull request is meant to address the issue #291

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6469a10) 92.60% compared to head (1891cca) 92.60%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          33       33           
  Lines        2245     2245           
=======================================
  Hits         2079     2079           
  Misses        166      166           
Flag Coverage Δ
base 92.67% <ø> (ø)
core 90.47% <ø> (ø)
files 92.34% <ø> (ø)
komamri 93.89% <ø> (ø)
plots 93.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cncastillo
Copy link
Member

Why is this not passing the CI for Windows Julia 1.9?

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (d85c67a) to head (f9d4cf9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files          33       33           
  Lines        2257     2257           
=======================================
  Hits         2078     2078           
  Misses        179      179           
Flag Coverage Δ
base 90.24% <ø> (ø)
core 90.30% <ø> (ø)
files 93.79% <ø> (ø)
komamri 93.95% <ø> (ø)
plots 93.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cncastillo
Copy link
Member

The documentation for this PR can be seen in:

https://juliahealth.org/KomaMRI.jl/previews/PR304/pluto-fat-sat-low-field/

docs/make.jl Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
@cncastillo
Copy link
Member

I did this properly in #377

@cncastillo cncastillo closed this Apr 20, 2024
@cncastillo cncastillo deleted the pluto-fat-sat-low-field branch May 23, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants