Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive this package in favor of TranscodingStreams? #62

Closed
jakobnissen opened this issue Mar 16, 2021 · 11 comments
Closed

Archive this package in favor of TranscodingStreams? #62

jakobnissen opened this issue Mar 16, 2021 · 11 comments

Comments

@jakobnissen
Copy link

I'm reasonably certain this package is deprecated in favor of TranscodingStreams and has been for a few years. Should we just archive it and put a big, fat sign up on the README that redirects people to TranscodingStreams?

@kescobo
Copy link
Member

kescobo commented Mar 16, 2021

Possible duplication of #61. In that issue, @StefanKarpinski mentions TranscodingStreams.jl, so maybe they're orthogonal? I don't think I've ever used either directly, so I'm not sure.

I do think it should be either archived or transferred to a different Org, its presence in BioJulia is mostly historical accident.

@jakobnissen
Copy link
Author

IIRC, Kenta Sato wrote this package to replace BufferedStreams - the NoopStream works like BufferedStreams, but better.

@feanor12
Copy link

I think the anchor functionality is missing in the other packages.

@KristofferC
Copy link
Member

KristofferC commented Jun 15, 2022

TranscodingStreams is much slower for me:

julia> using BufferedStreams, TranscodingStreams

julia> begin
           array = rand(UInt8, 1024*1024*256)
           tmp, io = mktemp()
           write(io, array)
           close(io)
       end

julia> function readchars(io)
           s = 0
           while !eof(io)
               s += read(io, UInt8)
           end
           return s
       end;

julia> open(tmp) do io
           @time readchars(BufferedInputStream(io, 128*2^10))
       end;
  0.136337 seconds (3 allocations: 128.172 KiB)

julia> open(tmp) do io
           @time readchars(NoopStream(io; bufsize=128*2^10))
       end;
  1.012437 seconds (5 allocations: 128.234 KiB)

So I think there is till value in this package.

@jakobnissen
Copy link
Author

@KristofferC good point. Since all of BioJulia's IO goes through TranscodingStreams, I think what your comment implies is that we should do our best to make TranscodingStreams much faster than it is currently. And I agree we shouldn't retire BufferedStreams until we can reasonably claim that users can switch to NoopStream without any loss of performance.

@KristofferC
Copy link
Member

While you are here, perhaps you can look at #64 heh.

@jakobnissen
Copy link
Author

Unfortunately, I dont have merge permissions for this repo (I'm not a maintainer). In fact, I'm pretty sure no-one is, and this package is unmaintained despite having 1,012 dependents.

@KristofferC
Copy link
Member

Since it is in the BioJulia org someone should have some power to be able to add new collaborators?

@jakobnissen
Copy link
Author

Whoops, I conflated this package with TranscodingStreams. I can look at #64 tomorrow

@stevengj
Copy link
Member

stevengj commented Jul 12, 2023

I think this can be closed? Sounds like we are keeping this package.

@KristofferC
Copy link
Member

At least until the performance in the replacement package has been improved to at least match this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants