Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImageSegmentation a subpackage of Images? #78

Closed
johnnychen94 opened this issue Sep 5, 2021 · 1 comment · Fixed by JuliaImages/Images.jl#990
Closed

Make ImageSegmentation a subpackage of Images? #78

johnnychen94 opened this issue Sep 5, 2021 · 1 comment · Fixed by JuliaImages/Images.jl#990

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Sep 5, 2021

Previously ImageSegmentation depends on Images, but now we're making it depending on ImageCore and ImageFiltering, so currently it's possible that we do @reexport ImageSegmentation in Images.

My vision on Images.jl is to move stable packages to Images.jl repo (JuliaImages/Images.jl#898) and reexport them from Images.jl. And I would also like to make our centralized documentation juliaimages.org to Images-exclusive; this said, the current ImageFeatures should host its own documentation unless we make it depending on smaller dependencies and included by Images like ImageSegmentation (if we do this way).

@timholy
Copy link
Member

timholy commented Sep 5, 2021

but now we're making it depending on ImageCore and ImageFiltering

Indeed even the latter will be only a test dependency. But your core point stands, of course nvm, it's always been a dependency...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants