From 3abf74f5e19a9526ce27ed5cad953ee67b3f3851 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sun, 5 Feb 2023 06:26:47 -0500 Subject: [PATCH 1/3] Add a link to the GitHub diff --- src/bump-stdlibs.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/bump-stdlibs.jl b/src/bump-stdlibs.jl index 7395edf..6520888 100644 --- a/src/bump-stdlibs.jl +++ b/src/bump-stdlibs.jl @@ -154,6 +154,8 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) "Bump invoked by: $(bumpstdlibs_sender_ping)", "Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)", "", + "Diff: $(git_url_markdown)/compare/$(stdlib_current_commit_in_upstream)...$(stdlib_latest_commit)" + "", "```", "\$ $(strip(string(changelog_cmd), '`'))", changelog, From 8b3dda9e24d2c22464c34945afe086fb37a28daa Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sun, 5 Feb 2023 06:30:27 -0500 Subject: [PATCH 2/3] Fix syntax --- src/bump-stdlibs.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bump-stdlibs.jl b/src/bump-stdlibs.jl index 6520888..f0902c9 100644 --- a/src/bump-stdlibs.jl +++ b/src/bump-stdlibs.jl @@ -154,7 +154,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) "Bump invoked by: $(bumpstdlibs_sender_ping)", "Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)", "", - "Diff: $(git_url_markdown)/compare/$(stdlib_current_commit_in_upstream)...$(stdlib_latest_commit)" + "Diff: $(git_url_markdown)/compare/$(stdlib_current_commit_in_upstream)...$(stdlib_latest_commit)", "", "```", "\$ $(strip(string(changelog_cmd), '`'))", From 9952ad00147f2c7f4a68969f52b220a62da6bd8b Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sun, 5 Feb 2023 06:38:25 -0500 Subject: [PATCH 3/3] Remove `.git` from the URL --- src/bump-stdlibs.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bump-stdlibs.jl b/src/bump-stdlibs.jl index f0902c9..e458079 100644 --- a/src/bump-stdlibs.jl +++ b/src/bump-stdlibs.jl @@ -142,6 +142,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) bumpstdlibs_sender_ping = isempty(bumpstdlibs_sender) ? "unknown user" : "@$(bumpstdlibs_sender)" julia_version = Base.VersionNumber(read("VERSION", String)) version_match = stdlib_version isa VersionNumber && Base.thispatch(julia_version) === Base.thispatch(stdlib_version) + url_for_diff = chopsuffix(git_url_markdown, ".git") pr_body_lines = String[ "Stdlib: $(stdlib.name)", "URL: $(git_url_markdown)", @@ -154,7 +155,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) "Bump invoked by: $(bumpstdlibs_sender_ping)", "Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)", "", - "Diff: $(git_url_markdown)/compare/$(stdlib_current_commit_in_upstream)...$(stdlib_latest_commit)", + "Diff: $(url_for_diff)/compare/$(stdlib_current_commit_in_upstream)...$(stdlib_latest_commit)", "", "```", "\$ $(strip(string(changelog_cmd), '`'))",