From 070da7147e511a85ca067748316cfcc636927588 Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Sun, 17 Nov 2019 20:06:57 +0000 Subject: [PATCH 1/5] add zero arg ReverseOrdering constructor --- Project.toml | 2 +- src/Compat.jl | 5 +++++ test/runtests.jl | 6 ++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index c82594b2a..c5a37b372 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "Compat" uuid = "34da2185-b29b-5c13-b0c7-acf172513d20" -version = "2.2.0" +version = "2.3.0" [deps] Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f" diff --git a/src/Compat.jl b/src/Compat.jl index 8424c8532..34c870cb7 100644 --- a/src/Compat.jl +++ b/src/Compat.jl @@ -93,6 +93,11 @@ if VERSION < v"1.4.0-DEV.329" Base.:∘(f, g, h...) = ∘(f ∘ g, h...) end +# https://github.com/JuliaLang/julia/pull/33736/ +if VERSION < v"1.4.0-DEV.493" + Base.Order.ReverseOrdering() = Base.Order.ReverseOrdering(Base.Order.Forward) +end + include("deprecated.jl") end # module Compat diff --git a/test/runtests.jl b/test/runtests.jl index 6e1f8b77c..bab5c0faa 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -97,4 +97,10 @@ end @test ∘(fs...)("ABC") == "AB" end +# https://github.com/JuliaLang/julia/pull/33736/ +@testset "ReverseOrdering constructor" begin + @test Base.Order.ReverseOrdering() == Base.Order.Reverse +end + + nothing From ebfce42f804d4c5fb44e7227fd030f24d1b95608 Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Sun, 17 Nov 2019 22:33:03 +0000 Subject: [PATCH 2/5] include 0 arg constructor in readme --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 84c719baa..483da2ee1 100644 --- a/README.md +++ b/README.md @@ -65,6 +65,8 @@ Currently, the `@compat` macro supports the following syntaxes: * `merge` methods with one and `n` `NamedTuple`s ([#29259]). (since Compat 2.0.0) +* `Base.Order.ReverseOrdering` has a zero arg constructor [#33736]. (since Compat 2.3.0) + ## Renaming ## New macros @@ -114,3 +116,4 @@ Note that you should specify the correct minimum version for `Compat` in the [#32628]: https://github.com/JuliaLang/julia/issues/32628 [#33129]: https://github.com/JuliaLang/julia/issues/33129 [#33568]: https://github.com/JuliaLang/julia/pull/33568 +[#33736]: http://github.com/JuliaLang/julia/pull/33736 From c8b01a33768db4560ee64d87b4289ec8f9aed06c Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Mon, 18 Nov 2019 09:05:00 +0000 Subject: [PATCH 3/5] Update README.md Co-Authored-By: Martin Holters --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 483da2ee1..24244f6d0 100644 --- a/README.md +++ b/README.md @@ -65,7 +65,7 @@ Currently, the `@compat` macro supports the following syntaxes: * `merge` methods with one and `n` `NamedTuple`s ([#29259]). (since Compat 2.0.0) -* `Base.Order.ReverseOrdering` has a zero arg constructor [#33736]. (since Compat 2.3.0) +* `Base.Order.ReverseOrdering` has a zero arg constructor [#33736]. (since Compat 3.0.0) ## Renaming From 4cf6a14ecbe7e8237961b47a2f0e644c612ea1be Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Mon, 18 Nov 2019 09:06:04 +0000 Subject: [PATCH 4/5] Update Project.toml --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index c5a37b372..0287d00ee 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "Compat" uuid = "34da2185-b29b-5c13-b0c7-acf172513d20" -version = "2.3.0" +version = "3.0.0" [deps] Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f" From 50388d1a937debc400236d6303ad9443a56d238c Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Mon, 18 Nov 2019 10:31:37 +0000 Subject: [PATCH 5/5] list version --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 24244f6d0..59f78e03e 100644 --- a/README.md +++ b/README.md @@ -74,7 +74,7 @@ Currently, the `@compat` macro supports the following syntaxes: ## Other changes * Function composition now supports multiple functions: `∘(f, g, h) = f ∘ g ∘ h` - and splatting `∘(fs...)` for composing an iterable collection of functions ([#33568]). + and splatting `∘(fs...)` for composing an iterable collection of functions ([#33568]). (since Compat 3.0.0) ## New types