Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for missing project file could be improved #2528

Closed
logankilpatrick opened this issue Apr 25, 2021 · 5 comments · Fixed by #2854
Closed

Error message for missing project file could be improved #2528

logankilpatrick opened this issue Apr 25, 2021 · 5 comments · Fixed by #2854

Comments

@logankilpatrick
Copy link
Member

I am trying to do:

(@v1.6) pkg> add https://github.com/danielsuo/Crypto.jl
    Updating git-repo `https://github.com/danielsuo/Crypto.jl`
ERROR: could not find project file in package at `https://github.com/danielsuo/Crypto.jl` maybe `subdir` needs to be specified

and it fails. I tried a git clone locally and it worked without issue. My guess is that the project structure is causing the issues?

@logankilpatrick
Copy link
Member Author

It looks like per here: https://discourse.julialang.org/t/error-could-not-find-project-file-in-package-at-https-github-com/44059 you can't add a package without a Project file, perhaps the error message wording could be improved?

@logankilpatrick
Copy link
Member Author

Ehh, maybe that error message is fine, I still have not had coffee yet so will let it sink in and revisit

@DilumAluthge
Copy link
Member

We could change project file to Project.toml file, if that helps?

@logankilpatrick
Copy link
Member Author

Yeah, that will do the trick

@KristofferC
Copy link
Member

It could be called JuliaProject.toml as well which I guess maybe is why it is just called project file. On the other hand, no one uses that so perhaps it is fine to just hard code Project.toml.

@KristofferC KristofferC changed the title Unable to install Crypto.jl in Julia 1.6 Error message for missing project file could be improved Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants