From 6e061322438f13c6548200f115f3c31b20860a30 Mon Sep 17 00:00:00 2001 From: Takafumi Arakaki Date: Sat, 7 May 2022 01:12:31 -0700 Subject: [PATCH] Revert "Clarify that `modifyproperty!` does not call `convert` (#45178)" (#45209) This reverts commit 350376b2baef2e60baa78efa42d4a590ac8a47da. --- base/docs/basedocs.jl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/base/docs/basedocs.jl b/base/docs/basedocs.jl index 86606b6112cff..b75e831c3d0e4 100644 --- a/base/docs/basedocs.jl +++ b/base/docs/basedocs.jl @@ -2758,11 +2758,6 @@ The syntax `@atomic max(a().b, c)` returns `modifyproperty!(a(), :b, max, c, :sequentially_consistent))`, where the first argument must be a `getfield` expression and is modified atomically. -Unlike [`setproperty!`](@ref Base.setproperty!), the default implementation of -`modifyproperty!` does not call `convert` automatically. Thus, `op` must return a value -that can be stored in the field `f` directly when invoking the default `modifyproperty!` -implementation. - See also [`modifyfield!`](@ref Core.modifyfield!) and [`setproperty!`](@ref Base.setproperty!). """