Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qrfact(SparseMatrixCSC) by wrapping SPQR. #10180

Merged
merged 3 commits into from
Feb 16, 2015
Merged

Add qrfact(SparseMatrixCSC) by wrapping SPQR. #10180

merged 3 commits into from
Feb 16, 2015

Conversation

andreasnoack
Copy link
Member

Also make \(SparseMatrixCSC) work for least squares problems.

@jiahao
Copy link
Member

jiahao commented Feb 12, 2015

👏

@andreasnoack
Copy link
Member Author

Now including the new files and with the typos corrected.

@ViralBShah
Copy link
Member

This also needs a mention in NEWS.

@ViralBShah ViralBShah added sparse Sparse arrays linear algebra Linear algebra labels Feb 13, 2015
…f the functions so we have to do that by default.
@andreasnoack
Copy link
Member Author

The test error is not related to this pr so I'll merge. The error is because a test matrix sometimes doesn't have zero pivots even though it has most of the time. We might want to adjust the test a bit if it shows up more often.

andreasnoack added a commit that referenced this pull request Feb 16, 2015
Add qrfact(SparseMatrixCSC) by wrapping SPQR.
@andreasnoack andreasnoack merged commit 7077bde into master Feb 16, 2015
@andreasnoack andreasnoack deleted the anj/spqr branch February 16, 2015 15:44
@tkelman
Copy link
Contributor

tkelman commented Feb 16, 2015

Can we use a known constant test matrix that causes that condition? CI failures should be taken seriously and if they have known, straightforward solutions we should fix them.

@andreasnoack
Copy link
Member Author

Yes, we can construct a matrix that fails deterministically instead, so that is the way to avoid this problem.

@andreasnoack
Copy link
Member Author

With ab72de8 we shouldn't see the random test failures from cholmod.jl anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants