Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate isimag #19949

Merged
merged 1 commit into from
Jan 12, 2017
Merged

deprecate isimag #19949

merged 1 commit into from
Jan 12, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jan 9, 2017

This pull request deprecates isimag (presently (tentatively) in favor of Base.iszero(real(z))). See discussion in #19947. Best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation maths Mathematical functions labels Jan 9, 2017
@stevengj
Copy link
Member

stevengj commented Jan 9, 2017

I think it should either deprecate to real(z) == 0 or wait until #19950 merges.

@ararslan ararslan mentioned this pull request Jan 10, 2017
@@ -1276,6 +1276,9 @@ eval(SparseArrays, :(broadcast_zpreserving!(f, C::SparseMatrixCSC, A::Union{Arra
@deprecate getindex(t::Tuple, r::AbstractArray) getindex(t, vec(r))
@deprecate getindex(t::Tuple, b::AbstractArray{Bool}) getindex(t, vec(b))

# Deprecate isimag (#19947).
@deprecate isimag(z::Number) Base.iszero(real(z))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Base. prefix may now be dropped, as #19950 has merged. 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Base. prefix may now be dropped, as #19950 has merged. 🙂

Cheers! Rebased dropping the qualification. Thanks!

@ararslan
Copy link
Member

Good to merge?

@StefanKarpinski StefanKarpinski merged commit d357955 into JuliaLang:master Jan 12, 2017
@Sacha0 Sacha0 deleted the depisimag branch January 12, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation maths Mathematical functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants