Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate vectorized sign methods in favor of dot syntax #20228

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jan 25, 2017

This pull request deprecates all remaining vectorized sign methods in favor of dot syntax. Best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation broadcast Applying a function over a collection labels Jan 25, 2017
@Sacha0 Sacha0 added this to the 0.6.0 milestone Jan 25, 2017
@@ -1166,7 +1166,7 @@ function (-)(B::BitArray)
end
return A
end
sign(B::BitArray) = copy(B)
broadcast(sign, B::BitArray) = copy(B)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

::typeof(sign)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. Good catch! Fixed on push. Thanks!

@pabloferz pabloferz merged commit 8197971 into JuliaLang:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants