Use same code path for count(pred, itr) as sum(pred, itr)

[dpsanders]

count(pred, itr) (currently) has the same functionality as sum(pred, itr), only slower:

julia> function bench(N)
       r = randn(N)
       @time count(i->i>1.96, r)
       @time sum(i->i>1.96, r)
       end
bench (generic function with 1 method)

After warmup on latest master:

julia> bench(10^8)
 0.108136 seconds
  0.075002 seconds

We could just define count(pred, itr) = sum(pred, itr) but the count function just seems to be redundant (EDITED according to @ararslan's comment below and #20404 ).

This came up in
https://discourse.julialang.org/t/compute-number-of-values-in-an-array-above-a-threshold/2167

[tkelman]

see #20404

[ararslan]

I very much disagree with this. To reiterate what I said in #20404 (comment), should we make Bool not a subtype of Number (see #19168), it makes more sense to count non-numbers than to sum them, even if we do still define arithmetic on Bools. The functionality of sum and count overlaps in some cases, but I think in general they serve different purposes.

[dpsanders]

Yes, I see what you mean; I hadn't seen #20404 before I posted.

In any case, count should not be 30% slower than sum in my example.

[dpsanders]

On current master, count is nearly twice as slow on my machine:

julia> bench(10^8)
  0.104584 seconds
  0.059525 seconds

julia> 0.104584 / 0.059525
1.7569760604787903

[dpsanders]

This seems to be fixed on latest master:

julia> r = randn(10^8);

julia> @btime count(i->i>1.96, $r)
  57.402 ms (0 allocations: 0 bytes)
2499971

julia> @btime sum(i->i>1.96, $r)
  56.915 ms (0 allocations: 0 bytes)
2499971