-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getsockname mirrors UNIX getsockname now. Added getpeername. #21825
Conversation
Huh? Several PR's are open that are starting a placeholder for 0.7 NEWS at the top of the file. |
test/socket.jl
Outdated
default_addr = IPv4("127.0.0.1") | ||
for (addr, porthint) in [(IPv4("127.0.0.1"), UInt16(11011)), | ||
(IPv6("::1"), UInt16(11012)), (getipaddr(), UInt16(11013))] | ||
port, listen_sock = listenany(addr, porthint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excess indent in this block
cd4f0c0
to
35e3896
Compare
Will merge after a green CI. |
@@ -3,6 +3,8 @@ Julia v0.7.0 Release Notes | |||
|
|||
New language features | |||
--------------------- | |||
* `getpeername` on a `TCPSocket` returns the address and port of the remote | |||
endpoint of the TCP connection ([#21825]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a library improvement, not a language feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref : #22141
Closes #21801
NEWS.md entry will have to wait till 0.6 is released.