Disentangle two uses of find_in_path: find_package, find_source_file #24320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vtjnash
reviewed
Oct 25, 2017
base/loading.jl
Outdated
| else | ||
| name = string(base,".jl") | ||
| function find_package(name::String) | ||
| endswith(name, ".jl") && (name = name[1:end-3]) |
There was a problem hiding this comment.
base = name[1:prevind(name, end - 2)] (prevind(end - 2) != end - 3)
vtjnash
approved these changes
Oct 25, 2017
|
F-it, I'm tired of waiting for the macOS build. This thing works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These used to be related functionalities, they are no longer related at all. Also remove the
load_hookcustom loader functionality. This was intended for Pkg3, but ended up not being usable.