Add support for _italics_ using underscores to the Markdown parser #25564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
reviewed
Jan 15, 2018
base/markdown/Common/inline.jl
Outdated
| @@ -14,6 +14,12 @@ function asterisk_italic(stream::IO, md::MD) | |||
| return result === nothing ? nothing : Italic(parseinline(result, md)) | |||
| end | |||
|
|
|||
| @trigger '_' -> | |||
| function asterisk_italic_underscore(stream::IO, md::MD) | |||
There was a problem hiding this comment.
This would be better named underscore_italic I think ;-)
ararslan
added
needs tests
Fix the naming scheme and allow the analogous bold syntax more natural ordering of asterisk/underscore bold/italic entries in markdown flavors Add NEWS entry Add tests for _italics_ and __bold__
|
I've squashed it down to one commit; if the functionality is agreeable, this should be good to go. |
StefanKarpinski
approved these changes
Jan 16, 2018
c42f
removed
needs news
|
Looks good to me. Just waaaaiting on Travis (other CI failures seem unrelated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia's base Markdown parser currently parses
*italics*but not_italics_.This pull request adds support for italics via underscores, as used on GitHub, Discourse, and Slack as specified in the original Markdown spec. Asterisks also continue to work.
Thanks to @c42f for help with this PR!