.! fails for BitVector

[stevengj]

For some reason, broadcasting ! to a BitVector fails in 0.7, though it works in 0.6, and map succeeds:

julia> .!BitVector(rand(Bool, 10))
ERROR: MethodError: no method matching !(::UInt64)
Closest candidates are:
  !(::Missing) at missing.jl:69
  !(::Bool) at bool.jl:31
  !(::Function) at operators.jl:787
Stacktrace:
 [1] #8 at ./broadcast.jl:438 [inlined]
 [2] macro expansion at ./broadcast.jl:950 [inlined]
 [3] macro expansion at ./simdloop.jl:73 [inlined]
 [4] chunkedcopyto!(::BitArray{1}, ::Base.Broadcast.Broadcasted{Nothing,Bool,Tuple{Base.OneTo{Int64}},Base.TupleLL{Tuple{Tuple{Bool},Tuple{Int64}},Base.TupleLLEnd},typeof(!),Base.TupleLL{BitArray{1},Base.TupleLLEnd}}) at ./broadcast.jl:949
 [5] copyto!(::BitArray{1}, ::Base.Broadcast.Broadcasted{Nothing,Bool,Tuple{Base.OneTo{Int64}},Base.TupleLL{Tuple{Tuple{Bool},Tuple{Int64}},Base.TupleLLEnd},typeof(!),Base.TupleLL{BitArray{1},Base.TupleLLEnd}}) at ./broadcast.jl:901
 [6] copyto! at ./broadcast.jl:860 [inlined]
 [7] copy at ./broadcast.jl:825 [inlined]
 [8] execute(::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{1},Base.Broadcast.Unknown,Nothing,Nothing,typeof(!),Base.TupleLL{BitArray{1},Base.TupleLLEnd}}) at ./broadcast.jl:1268
 [9] top-level scope

julia> map(x -> !x, BitVector(rand(Bool, 10)))
10-element BitArray{1}:
 false
 false
 false
  true
 false
 false
 false
  true
  true
  true

I noticed this because it caused Pkg.update() to fail for me, since .! on a BitVector is used by pkg/cache.jl.

[stevengj]

.!rand(Bool, 10) works, so this seems specific to the broadcast code for BitVector.

[KristofferC]

Thi requires some PR to be merged into master to occur? The Tim Holy broadcasting one I guess?

[stevengj]

Sorry, I just realized that I'm not on master, I'm on the teh-jn/lazydotfuse branch. It looks like this is a bug with #25377, since ! is incorrectly listed as a ChunkableOp, which would only be true if #25435 had been merged.

cc @timholy

[mbauman]

Yup, this is my mistake. ! is not "chunkable" — I just fixed that locally and I'll push it now.