Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more unicode dotty operators #26262

Merged
merged 7 commits into from
Mar 1, 2018
Merged

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Feb 28, 2018

This PR adds the Unicode characters … ⁝ ⋮ ⋱ ⋰ ⋯ as binary operators with the same precedence as : and ... (Fixes #24269.) Breaking because ⋮ ⋱ ⋰ ⋯ were formerly parsed as identifiers.

It also changes ≔ ⩴ ≕ from comparison precedence to assignment precedence, since colon-equals is an assignment by convention (and we already parse := with assignment precedence). Also breaking.

I doubt that this affects any extant code.

In the future, we may want to also accept (U+2af6) and/or (U+fe19) as synonyms for (U+205d) or (U+22ee), but #25157 needs to be fixed before we can canonicalize operators. That won't be a breaking change since ⫶ ︙ are not currently valid in identifiers.

@stevengj stevengj added breaking This change will break code parser Language parsing and surface syntax triage This should be discussed on a triage call labels Feb 28, 2018
@ararslan ararslan added the unicode Related to unicode characters and encodings label Feb 28, 2018
@stevengj
Copy link
Member Author

stevengj commented Mar 1, 2018

CI failure on Win32 is #26255. Not sure what the Win64 failure is — I'm not seeing the error message in the log?

@JeffBezanson JeffBezanson merged commit 4c75937 into JuliaLang:master Mar 1, 2018
@ararslan ararslan removed the triage This should be discussed on a triage call label Mar 1, 2018
@stevengj stevengj deleted the unidotops branch March 1, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change will break code parser Language parsing and surface syntax unicode Related to unicode characters and encodings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more Unicode dots as infix operators
3 participants