errors in test/loading.jl leave LOAD_PATH and DEPOT_PATH in a bad state

[vtjnash]

errors in test/loading.jl leave LOAD_PATH and DEPOT_PATH in a bad state, as seen in
https://ci.appveyor.com/project/JuliaLang/julia/build/1.0.27712/job/ndh5g93sk68t3nhg#L4861

4861Error in testset loading:
4862Error During Test at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:19
4863  Got exception LoadError("C:\\projects\\julia\\julia-3172bd26fa\\share\\julia\\test\\loading.jl", 346, SystemError("mkdir", 22, "C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\jl_17A3.tmp\\packages\\A\\lpt7")) outside of a @test
4864  LoadError: SystemError (with C:\Users\appveyor\AppData\Local\Temp\1\jl_17A3.tmp\packages\A\lpt7): mkdir: Invalid argument
4865  Stacktrace:
4866   [1] #systemerror#43(::String, ::Function, ::Symbol, ::Bool) at .\error.jl:106
4867   [2] #systemerror at .\none:0 [inlined]
4868   [3] #mkdir#7(::UInt16, ::Function, ::String) at .\file.jl:167
4869   [4] (::getfield(Base.Filesystem, Symbol("#kw##mkdir")))(::NamedTuple{(:mode,),Tuple{UInt16}}, ::typeof(mkdir), ::String) at .\none:0
4870   [5] #mkpath#8(::UInt16, ::Function, ::String) at .\file.jl:212
4871   [6] (::getfield(Base.Filesystem, Symbol("#kw##mkpath")))(::NamedTuple{(:mode,),Tuple{UInt16}}, ::typeof(mkpath), ::String) at .\none:0
4872   [7] #mkpath#8(::UInt16, ::Function, ::String) at .\file.jl:210
4873   [8] mkpath(::String) at .\file.jl:207
4874   [9] make_entry_point(::String, ::String, ::Base.UUID) at C:\projects\julia\julia-3172bd26fa\share\julia\test\loading.jl:321
4875   [10] (::getfield(Main.Test5Main_loading, Symbol("##70#76")))(::IOStream) at C:\projects\julia\julia-3172bd26fa\share\julia\test\loading.jl:405
4876   [11] #open#304(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::getfield(Main.Test5Main_loading, Symbol("##70#76")), ::String, ::Vararg{String,N} where N) at .\iostream.jl:369
4877   [12] open(::Function, ::String, ::String) at .\iostream.jl:367
4878   [13] top-level scope at C:\projects\julia\julia-3172bd26fa\share\julia\test\loading.jl:391
4879   [14] include at .\boot.jl:317 [inlined]
4880   [15] include_relative(::Module, ::String) at .\loading.jl:1089
4881   [16] include(::Module, ::String) at .\sysimg.jl:29
4882   [17] include(::String) at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:13
4883   [18] macro expansion at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:292 [inlined]
4884   [19] macro expansion at C:\projects\julia\usr\share\julia\stdlib\v0.7\Test\src\Test.jl:1080 [inlined]
4885   [20] macro expansion at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:21 [inlined]
4886   [21] macro expansion at .\util.jl:289 [inlined]
4887   [22] top-level scope at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:19 [inlined]
4888   [23] top-level scope at .\<missing>:0
4889   [24] eval at .\boot.jl:319 [inlined]
4890   [25] #runtests#3(::UInt128, ::Function, ::String, ::String, ::Bool) at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:25
4891   [26] #runtests at .\none:0 [inlined] (repeats 2 times)
4892   [27] (::getfield(Distributed, Symbol("##112#114")){Distributed.CallMsg{:call_fetch}})() at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:269
4893   [28] run_work_thunk(::getfield(Distributed, Symbol("##112#114")){Distributed.CallMsg{:call_fetch}}, ::Bool) at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:56
4894   [29] macro expansion at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:270 [inlined]
4895   [30] (::getfield(Distributed, Symbol("##111#113")){Distributed.CallMsg{:call_fetch},Distributed.MsgHeader,Sockets.TCPSocket})() at .\task.jl:257
4896  in expression starting at C:\projects\julia\julia-3172bd26fa\share\julia\test\loading.jl:346
4897Error in testset bigint:
4898Error During Test at nothing:1
4899  Test threw exception RemoteException(7, CapturedException(ArgumentError("Package Test not found in current path:\n - Run `Pkg.add(\"Test\")` to install the Test package.\n"), Any[(require at loading.jl:871, 1), (eval at boot.jl:319 [inlined], 1), (#runtests#3 at testdefs.jl:17, 1), (#runtests at none:0 [inlined], 2), (#112 at process_messages.jl:269, 1), (run_work_thunk at process_messages.jl:56, 1), (macro expansion at process_messages.jl:270 [inlined], 1), (#111 at task.jl:257, 1)]))
4900  Expression: bigint
4901  On worker 7:
4902  ArgumentError: Package Test not found in current path:
4903   - Run `Pkg.add("Test")` to install the Test package.
4904  
4905  require at .\loading.jl:871
4906  eval at .\boot.jl:319 [inlined]
4907  #runtests#3 at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:17
4908  #runtests at .\none:0 [inlined] (repeats 2 times)
4909  #112 at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:269
4910  run_work_thunk at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:56
4911  macro expansion at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:270 [inlined]
4912  #111 at .\task.jl:257
4913Error in testset bigfloat:
4914Error During Test at nothing:1
4915  Test threw exception RemoteException(7, CapturedException(ArgumentError("Package Test not found in current path:\n - Run `Pkg.add(\"Test\")` to install the Test package.\n"), Any[(require at loading.jl:871, 1), (eval at boot.jl:319 [inlined], 1), (#runtests#3 at testdefs.jl:17, 1), (#runtests at none:0 [inlined], 2), (#112 at process_messages.jl:269, 1), (run_work_thunk at process_messages.jl:56, 1), (macro expansion at process_messages.jl:270 [inlined], 1), (#111 at task.jl:257, 1)]))
4916  Expression: bigfloat
4917  On worker 7:
4918  ArgumentError: Package Test not found in current path:
4919   - Run `Pkg.add("Test")` to install the Test package.
4920  
4921  require at .\loading.jl:871
4922  eval at .\boot.jl:319 [inlined]
4923  #runtests#3 at C:\projects\julia\julia-3172bd26fa\share\julia\test\testdefs.jl:17
4924  #runtests at .\none:0 [inlined] (repeats 2 times)
4925  #112 at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:269
4926  run_work_thunk at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:56
4927  macro expansion at C:\projects\julia\usr\share\julia\stdlib\v0.7\Distributed\src\process_messages.jl:270 [inlined]
4928  #111 at .\task.jl:257

[vtjnash]

I think this is now handled in the test runner (since #46602)

[KristofferC]

I think that was a typo to the real PR.

[vtjnash]

Thanks, I dropped the last number