1.5 beta allunique errors with Unitful

[Tokazama]

On the most recent 1.5 beta release I get the following error.

julia> using Unitful

julia> using Unitful: s

julia> allunique((1.0:1.0:10.0)s)
ERROR: DimensionError: s and 0 are not dimensionally compatible.
Stacktrace:
 [1] convert(::Type{Quantity{Float64,𝐓,Unitful.FreeUnits{(s,),𝐓,nothing}}}, ::Int64) at /Users/zchristensen/.julia/packages/Unitfu
l/KE9TK/src/conversion.jl:111
 [2] Base.TwicePrecision{Quantity{Float64,𝐓,Unitful.FreeUnits{(s,),𝐓,nothing}}}(::Int64, ::Int64) at ./twiceprecision.jl:185
 [3] zero(::Type{Base.TwicePrecision{Quantity{Float64,𝐓,Unitful.FreeUnits{(s,),𝐓,nothing}}}}) at ./twiceprecision.jl:260
 [4] allunique(::StepRangeLen{Quantity{Float64,𝐓,Unitful.FreeUnits{(s,),𝐓,nothing}},Base.TwicePrecision{Quantity{Float64,𝐓,Unitful
.FreeUnits{(s,),𝐓,nothing}}},Base.TwicePrecision{Quantity{Float64,𝐓,Unitful.FreeUnits{(s,),𝐓,nothing}}}}) at ./set.jl:390
 [5] top-level scope at REPL[3]:1

This does raise some things that could probably be addressed in Unitful.jl but I wonder if it would make more sense to just have allunique(::AbstractRange) = true.

[sostock]

I wonder if it would make more sense to just have allunique(::AbstractRange) = true

One can actually create ranges that are not allunique:

julia> LinRange(1.0, 1.0, 5)
5-element LinRange{Float64}:
 1.0,1.0,1.0,1.0,1.0

[simeonschaub]

I think this should just be a matter of replacing step(r) != zero(T) with !iszero(step(r)) in the lines here.