Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more isreadable/iswriteable/isreadonly functions #3872

Merged
merged 1 commit into from
Jul 29, 2013

Conversation

stevengj
Copy link
Member

We already export these functions, this just adds definitions for more stream types.

(It would be nice to add them for File objects too, but that seems like it requires one to modify libuv to add a new function that calls fcntl(fd, F_GETFL) or the Windows equivalent thereof.)

@stevengj
Copy link
Member Author

PS. Note that we aren't entirely consistent on the spelling. We have iswriteable but IOBuffer.writable, for example. According to Google, the spelling "writable" is more common, so we might consider switching and deprecating the old spelling.

@pao
Copy link
Member

pao commented Jul 29, 2013

Keno added a commit that referenced this pull request Jul 29, 2013
add more isreadable/iswriteable/isreadonly functions
@Keno Keno merged commit 1ffed5d into JuliaLang:master Jul 29, 2013
@Keno
Copy link
Member

Keno commented Jul 29, 2013

I will merge this an we can do the rename/deprecation in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants