Add LinearAlgebra.normalize fallback for scalars (#44835) #44925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix NaN == NaN error
mikerouleau
force-pushed
the
mr/normalize
branch
from
54fbec7
to
ca40da4
Compare
|
Thanks! Needs an entry in |
stevengj
reviewed
Apr 12, 2022
stevengj
reviewed
Apr 12, 2022
stevengj
approved these changes
Apr 12, 2022
|
The Windows CI processes timed out. Shall we merge this as is or first rebase and give CI another chance? |
|
@dkarrasch That's probably not a decision for me, but I'm fine either way. What generally would cause the windows CI to time out in this manner? It doesn't look related to anything in this PR and I don't see anything explicitly failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fallback methods LinearAlgebra.normalize(x), LinearAlgebra.normalize(x,p::Real) and related tests. These are particularly useful when x is a scalar (closes #44835).