Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in doctest CI (in a full source build) because it can't find python3 during mbedtls tests #45745

Open
ViralBShah opened this issue Jun 19, 2022 · 10 comments
Labels
building Build system, or building Julia or its dependencies

Comments

@ViralBShah
Copy link
Member

ViralBShah commented Jun 19, 2022

After the Sparse stdlibs bump PR was merged into master, the doctest CI failed because it seems to be running certain steps that don't otherwise seem to run in other PRs. It seems to need python3.

https://build.julialang.org/#/builders/54/builds/6896/steps/12/logs/stdio

checking for size_t... -- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS - Success
/usr/bin/env: python3: No such file or directory
CMake Error at tests/CMakeLists.txt:21 (message):
  Cannot build test suites without Python 3
-- Configuring incomplete, errors occurred!
See also "/buildworker/worker/doctest_linux64/build/deps/scratch/mbedtls-2.28.0/CMakeFiles/CMakeOutput.log".
make[2]: *** [scratch/mbedtls-2.28.0/build-configured] Error 1
make[2]: *** Waiting for unfinished jobs....

The operation being performed is full-source-dist and it seems to have issues with Makefile dependencies as well:

make JULIA_PRECOMPILE=0 USE_BINARYBUILDER=0 full-source-dist

@DilumAluthge @staticfloat May either of you know what is up?

@ViralBShah ViralBShah added the building Build system, or building Julia or its dependencies label Jun 19, 2022
@inkydragon
Copy link
Sponsor Member

inkydragon commented Jun 19, 2022

It looks like the test requires python3.

if(NOT MBEDTLS_PYTHON_EXECUTABLE)
    message(FATAL_ERROR "Cannot build test suites without Python 3")
endif()

https://github.com/Mbed-TLS/mbedtls/blob/8b3f26a5ac38d4fdccbc5c5366229f3e01dafcc0/tests/CMakeLists.txt#L20-L22

Python 3.6 to generate the test code, and to generate sample programs in the development branch.

—— Tool versions | Mbed-TLS/mbedtls

So just don't build test:

-DENABLE_TESTING=OFF

https://github.com/JuliaLang/julia/pull/45712/files#diff-137328a9cba83316ac89a90f305a629a1a7c585e49604af0222c54504fdb825fR9

@ViralBShah
Copy link
Member Author

The build dependencies in full source build were broken because of LBT. That is fixed in #45746

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 21, 2022

I was told this runs on buildkite now, but it hasn’t gotten turned off yet here. Been broken for awhile though

@inkydragon
Copy link
Sponsor Member

Not sure which commit fixed it, but now doctest can be built successfully.
https://build.julialang.org/#/builders/54

@ViralBShah
Copy link
Member Author

The doctest was not broken per se- it was only an issue in the full source build.

@ViralBShah ViralBShah changed the title Failure in doctest CI because it can't find python3 Failure in doctest CI (in a full source build) because it can't find python3 during mbedtls tests Jul 2, 2022
@ViralBShah
Copy link
Member Author

@DilumAluthge Do you know if this is still an issue?

@DilumAluthge
Copy link
Member

The issue here is about the make full-source-dist step, right? If so, then this issue is not yet resolved, because we actually lost that CI job in the Buildkite transition, and we need to add it back.

Cross-ref JuliaCI/julia-buildkite#190

@DilumAluthge
Copy link
Member

So we should probably keep this issue open until JuliaCI/julia-buildkite#190 is fixed, and then we can double-check that this issue is fixed.

@vtjnash vtjnash added this to the 1.9 milestone Feb 15, 2023
@KristofferC
Copy link
Sponsor Member

Having doctests fail in a special build seems very far from being a release blocker.

@KristofferC KristofferC removed this from the 1.9 milestone Feb 21, 2023
@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 21, 2023

I believe this was on regular CI that tests is the full source build works, not something special I was doing.

But it runs separately I think, once a day or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

No branches or pull requests

5 participants