Inconsistency in choice of libgcc_s version on macOS

[fxcoudert]

We're having trouble building Julia 1.8.4 from source in Homebrew, on macOS Intel. The reason is that there is an inconsistency in the choice of libgcc_s version. At runtime, the logic is (

julia/stdlib/CompilerSupportLibraries_jll/src/CompilerSupportLibraries_jll.jl

Line 34 in 00177eb

elseif Sys.isapple()

):

elseif Sys.isapple()
    if arch(HostPlatform()) == "aarch64" || libgfortran_version(HostPlatform()) == v"5"
        const libgcc_s = "@rpath/libgcc_s.1.1.dylib"
    else
        const libgcc_s = "@rpath/libgcc_s.1.dylib"
    end

but the logic hasn't been adapted to be identical when libraries are copied over (

julia/deps/csl.mk

Line 78 in cc5bc87

ifeq ($(APPLE_ARCH),arm64)

):

ifeq ($(APPLE_ARCH),arm64)
$(eval $(call copy_csl,$(call versioned_libname,libgcc_s,1.1)))
else
$(eval $(call copy_csl,$(call versioned_libname,libgcc_s,1)))
endif

[giordano]

@staticfloat do we have already a way to know the gcc/libgfortran version?

[fxcoudert]

The same logic is distributed in many places. In Make.inc it is right:

# On macOS, libgcc_s has soversion 1.1 always on aarch64 and only for GCC 12+
# (-> libgfortran 5) on x86_64
ifeq ($(OS),Darwin)
ifeq ($(ARCH),aarch64)
LIBGCC_NAME := libgcc_s.1.1.$(SHLIB_EXT)
else
ifeq ($(LIBGFORTRAN_VERSION),5)
LIBGCC_NAME := libgcc_s.1.1.$(SHLIB_EXT)
else
LIBGCC_NAME := libgcc_s.1.$(SHLIB_EXT)
endif
endif
endif

base/Makefile has the same code (not sure why it's duplicated). deps/csl.mk has it wrong, but I do not know if LIBGFORTRAN_VERSION is set/defined and can be used in that file.