You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using a Tuple here will allow ndims to be constant-propagated without relying on the compiler. It also reduces allocations in various functions, as vectors don't need to be allocated.
Such a change would be mildly breaking, but seems worthwhile. FFTW has largely been updated to accept Tuples as regions, and some other dependencies might need to be looked at.
The text was updated successfully, but these errors were encountered:
jishnub
changed the title
Convert 1:ndims(X) to ntuple(identity, ndims(X)
Convert 1:ndims(X) to ntuple(identity, ndims(X))Mar 29, 2023
An example:
AbstractFFTs.jl/src/definitions.jl
Line 62 in a25656d
Using a
Tuple
here will allowndims
to be constant-propagated without relying on the compiler. It also reduces allocations in various functions, as vectors don't need to be allocated.Such a change would be mildly breaking, but seems worthwhile. FFTW has largely been updated to accept
Tuple
s as regions, and some other dependencies might need to be looked at.The text was updated successfully, but these errors were encountered: