Improve inferrability of [region...] #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following problem:
```julia
julia> docat(v) = [v...]
docat (generic function with 1 method)
julia> code_typed(docat, (UnitRange{Int},))
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = Core._apply_iterate(Base.iterate, Base.vect, v)::Vector{_A} where _A
└── return %1
) => Vector{_A} where _A
julia> code_typed(docat, (Vector{Int},))
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = Core._apply_iterate(Base.iterate, Base.vect, v)::Union{Vector{Any}, Vector{Int64}}
└── return %1
) => Union{Vector{Any}, Vector{Int64}}
```
Essentially, because `region...` is implemented via the parser,
it relies on the call `vect(args...)` and the risk is that `args`
might be empty, which causes it to return `Vector{Any}`.
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 67.16% 67.16%
=======================================
Files 3 3
Lines 402 402
=======================================
Hits 270 270
Misses 132 132
Continue to review full report at Codecov.
|
stevengj
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following problem:
Essentially, because
region...is implemented via the parser,it relies on the call
vect(args...)and the risk is thatargsmight be empty, which causes it to return
Vector{Any}.