Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent to library from being serialized at precompile time #197

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Apr 19, 2021

The interpolated variable libfftw3 will evaluate at precompile time to the path to the local directory of the fftw library. This means that if you e.g. build a sysimage using FFTW and move it somewhere else that sysimage will not work properly. Instead, use :libfftw3 which evaluates to the variable libfftw3 which is set during runtime. This is likely what was originally intended.

cc @staticfloat @giordano @andreasnoack

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #197 (8320c0a) into master (53fe689) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   62.79%   62.79%           
=======================================
  Files           5        5           
  Lines         422      422           
=======================================
  Hits          265      265           
  Misses        157      157           
Impacted Files Coverage Δ
src/fft.jl 63.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fe689...8320c0a. Read the comment docs.

@staticfloat staticfloat merged commit 3d69222 into master Apr 19, 2021
@ararslan ararslan deleted the kc/path_compile_time branch April 19, 2021 17:58
@andreasnoack
Copy link
Member

It would be great with a new release that includes this fix.

@ararslan
Copy link
Member

FYI master is now 1.6 only, so if we wanted a patch with this we'd need to do a backport, right?

@andreasnoack
Copy link
Member

1.6 is all I need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants