Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statement of Need #179

Closed
ludgerpaehler opened this issue Dec 10, 2021 · 5 comments
Closed

Statement of Need #179

ludgerpaehler opened this issue Dec 10, 2021 · 5 comments

Comments

@ludgerpaehler
Copy link

Per Review Criteria

Do the authors clearly state what problems the software is designed to solve and who the target audience is?

I believe what would really help here is to more clearly establish the rules underlying the definition of a measure in the "Why", hence leading into the definition of a probability measure essentially adding the probability constraint. As is, the "Why" is a little hard to read for someone who does not already know measure theory.

@ludgerpaehler ludgerpaehler changed the title JuliaCon Review: Statement of Need Statement of Need Dec 10, 2021
@cscherrer
Copy link
Collaborator

Hi @ludgerpaehler , @mschauer and I were just discussing this. Most things under "Documentation" in the criteria seem to be about the repository, not the paper. Just to be sure we understand right, would adding this information in the documentation address your concern?

@ludgerpaehler
Copy link
Author

@cscherrer sorry for the belated reply, yes, absolutely! My concerns were mostly about the docs :)

@mschauer
Copy link
Member

#199 now gives context and states the core audience (powering PPL work in Julia behind the scenes)

@cscherrer
Copy link
Collaborator

Ok to close @ludgerpaehler ?

@ludgerpaehler
Copy link
Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants