Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some stray untyped global variables #523

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix some stray untyped global variables #523

merged 1 commit into from
Aug 17, 2023

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Aug 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6f5e5bb) 76.59% compared to head (0974edf) 76.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files          35       35           
  Lines        3739     3739           
=======================================
  Hits         2864     2864           
  Misses        875      875           
Files Changed Coverage Δ
src/common.jl 80.10% <ø> (ø)
...polynomials/standard-basis/immutable-polynomial.jl 97.67% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani
Copy link
Member

Thanks!! (How did you identify these?)

@jverzani jverzani merged commit 5f5ba86 into JuliaMath:master Aug 17, 2023
20 of 21 checks passed
@nsajko nsajko deleted the g branch August 17, 2023 21:44
@nsajko
Copy link
Contributor Author

nsajko commented Aug 17, 2023

You're welcome! Found these using varinfo, which can list all global names, and then checked which names were variable by trying to assign (e.g., Polynomials.ImmutablePolynomial = 3). The reason I did this in the first place was because ImmutablePolynomial being untyped was causing type inference issues in my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants