Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAM Potential #2

Open
cortner opened this issue Jan 10, 2024 · 3 comments
Open

EAM Potential #2

cortner opened this issue Jan 10, 2024 · 3 comments

Comments

@cortner
Copy link
Member

cortner commented Jan 10, 2024

The next potential to transfer from JuLIP will be EAM. Do we want this here, or should it live in a separate repo? In some ways EAM are a but more complex e.g. due to the many file formats one needs to support. At the moment JuLIP is reading in EAM files via ASE then importing the data into Julia and generating the potential.

@mfherbst
Copy link
Member

Is it possible to do something without the python dependency (i.e. is there a simple format one could support in pure Julia). If this is not possible, then I would probably have it as a separate package to avoid the hard-coded dependency on python.

@cortner
Copy link
Member Author

cortner commented Jan 11, 2024

Yes we have a pure Julia implementation of one of the EAM formats.

@mfherbst
Copy link
Member

Ok than my gut would be to stick with our current philosophy and keep the number of packages small (splitup can be done later). The pyhon-dependent stuff you could put into an extmodule triggered, e.g. by ASEconvert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants