Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support CoolProp on Apple M1 #5468

Closed
longemen3000 opened this issue Sep 12, 2022 · 5 comments · Fixed by #5482
Closed

support CoolProp on Apple M1 #5468

longemen3000 opened this issue Sep 12, 2022 · 5 comments · Fixed by #5482

Comments

@longemen3000
Copy link
Contributor

seems that the result binary does not include apple M1 in its dependencies. ref: CoolProp/CoolProp.jl#20

@longemen3000
Copy link
Contributor Author

seems that it only needs a rebuild? the version is the same, and the last commit was two weeks before the launch of apple M1

@giordano
Copy link
Member

Did you see the pinned issue #2763?

@longemen3000
Copy link
Contributor Author

longemen3000 commented Sep 13, 2022

the mention of apple was cut short hahaha
image
in particular, i don't see any problems with the constraints imposed by the issue, but i will tag @barche . basically, for support of CoolProp in apple M1, the package needs to have a julia >= 1.6 compat and a new version, right?

@longemen3000
Copy link
Contributor Author

longemen3000 commented Sep 13, 2022

the part of a new version number in the JLL, what does that mean? 6.4.1+(n+1) ? or 6.4.2 ?

@barche
Copy link
Contributor

barche commented Sep 13, 2022

I made a PR with 6.4.2, we'll see how it goes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants