Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ownership of join method into a separate package #17

Open
krynju opened this issue Nov 4, 2022 · 1 comment
Open

Move ownership of join method into a separate package #17

krynju opened this issue Nov 4, 2022 · 1 comment

Comments

@krynju
Copy link
Member

krynju commented Nov 4, 2022

Currently DTables implements a join method for any tables.jl compatible type
The problem is that DTables.jl shouldn't export it as it is not the goal of the package to provide generic functions like this

For other functions we're using generic implementations coming from TableOperations.jl, so we should do the same for joins

@krynju
Copy link
Member Author

krynju commented Nov 5, 2022

Better idea: add function definitions to dataapi that just return true/false based on whether the type implements the operation for their type; else fallback to default implementation stored in DTables that is not exported

Something like: has_innerjoin etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant