Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FigurePosition and FigureSubposition were mirroring GridPosition and GridSubposition from GridLayoutBase, with the only difference that they stored a Figure reference so they could be used in commands like
Axis(f[1, 1])
. What didn't work was plotting into similar lookingGridPositions
:This works now because GridLayouts have a
parent
field which can optionally be set to some parent object (usually a Figure) so that it's known who the GridLayout belongs to. I could delete all the mirrored code and gain some functionality, but it's of course slightly breaking, in case people were writing functions withFigurePosition
orFigureSubposition
arguments. These would need to be changed toGridPosition
andGridSubposition
. All other syntax stayed the same.