Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Julia 1.10 due to zombie I/O resources #5

Closed
MilesCranmer opened this issue Aug 8, 2023 · 1 comment · Fixed by #6
Closed

Incompatibility with Julia 1.10 due to zombie I/O resources #5

MilesCranmer opened this issue Aug 8, 2023 · 1 comment · Fixed by #6

Comments

@MilesCranmer
Copy link
Contributor

x-post comonicon/Comonicon.jl#249 and JuliaLang/julia#50839

It seems like on Julia 1.10, this package is causing precompilation/builds of downstream dependencies to hang. According to Tim Holy, this is due to I/O resources being opened during module definition:

If you open an I/O resource during module definition, you now (Julia 1.10+) have to close it before exiting the module. Example of a fix:

I can't remember if the 2nd PR was needed to fix precompilation, but I don't think so. But digging turned up more evidence that we were doing a bad job of freeing resources, so responding to the changes in 1.10 made the package better.

Does anything stand out as causing this issue? I'd be happy to submit a PR.

@MilesCranmer
Copy link
Contributor Author

Should be fixed with #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant