Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Wrong get_control_deriv for LockedAmplitude #77

Closed
goerz opened this issue Apr 17, 2024 · 0 comments · Fixed by #78
Closed

Wrong get_control_deriv for LockedAmplitude #77

goerz opened this issue Apr 17, 2024 · 0 comments · Fixed by #78
Labels
bug Something isn't working

Comments

@goerz
Copy link
Member

goerz commented Apr 17, 2024

Via @mrs504aa in https://github.com/orgs/JuliaQuantumControl/discussions/64:

julia> using QuantumPropagators.Amplitudes: LockedAmplitude, ShapedAmplitude

julia> using QuantumControlBase: get_control_deriv

julia> shape(t) = 1.0
shape (generic function with 1 method)

julia> ampl1 = LockedAmplitude(shape)
LockedAmplitude(::typeof(shape))

julia> get_control_deriv(ampl1, shape)
ERROR: type LockedContinuousAmplitude has no field control

The correct result for any call to get_control_deriv with a LockedAmplitude is 0.0 (as the amplitude does not depend on any control, by definition)

@goerz goerz added the bug Something isn't working label Apr 17, 2024
@goerz goerz closed this as completed in #78 Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant