Weird MethodError with sample

[domluna]

julia> import ReinforcementLearningBase: interact!, getstate, reset!, plotenv,
       actionspace, sample

julia> using ReinforcementLearningEnvironmentGym
[ Info: Recompiling stale cache file /Users/domluna/.julia/compiled/v1.0/ReinforcementLearningEnvironmentGym/NBild.ji for ReinforcementLearningEnvironmentGym [1053412c-b184-11e8-2eb2-ef51b44fed15]

julia>

julia>

julia>

julia> env = GymEnv("CartPole-v1")
/Users/domluna/.julia/conda/3/lib/python3.7/site-packages/gym/envs/registration.py:14: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.
  result = entry_point.load(False)
GymEnv{ReinforcementLearningBase.DiscreteSpace,ReinforcementLearningBase.BoxSpace{Float32,1}}(PyObject <TimeLimit<CartPoleEnv<CartPole-v1>>>, ReinforcementLearningBase.BoxSpace{Float32,1}(Float32[-4.8, -3.40282e38, -0.418879, -3.40282e38], Float32[4.8, 3.40282e38, 0.418879, 3.40282e38]), ReinforcementLearningBase.DiscreteSpace(2, 1), PyObject array([-0.02771541,  0.03014857, -0.0028666 ,  0.00249575]))

julia> sample(env.actionspace)
ERROR: MethodError: no method matching sample(::ReinforcementLearningBase.DiscreteSpace)
Closest candidates are:
  sample(::ReinforcementLearningBase.MultiBinarySpace) at /Users/domluna/.julia/packages/ReinforcementLearningBase/rsuom/src/spaces/multibinaryspace.jl:9
  sample(::ReinforcementLearningBase.DiscreteSpace) at /Users/domluna/.julia/packages/ReinforcementLearningBase/rsuom/src/spaces/discretespace.jl:7
  sample(::ReinforcementLearningBase.BoxSpace) at /Users/domluna/.julia/packages/ReinforcementLearningBase/rsuom/src/spaces/boxspace.jl:30
  ...
Stacktrace:
 [1] top-level scope at none:0

[jbrea]

I don't fully understand this issue, but I think if you replace the first line with

julia> import ReinforcementLearningEnvironmentGym: interact!, getstate, reset!, plotenv,
       actionspace, sample

it should work.

[domluna]

Thanks @jbrea that works but I'm not sure why. sample isn't defined anywhere in ReinforcementLearningEnvironmentGym, nor is it imported in the module.

[findmyway]

I'm closing this issue since I just tagged a new release and sample is not included in the API now.

By the way, your JuliaFormatter.jl is awesome! 👍