Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you support damping in urdf? #559

Open
tkoolen opened this issue Jun 20, 2019 · 2 comments
Open

Do you support damping in urdf? #559

tkoolen opened this issue Jun 20, 2019 · 2 comments

Comments

@tkoolen
Copy link
Collaborator

tkoolen commented Jun 20, 2019

Do you support damping in urdf?
<dynamics damping="0.6"/>
If not, how can I add one?

Originally posted by @Islam0mar in #317 (comment)

@tkoolen
Copy link
Collaborator Author

tkoolen commented Jun 20, 2019

Opened a new issue for this.

Damping coefficients are not stored in RigidBodyDynamics Joints; in general the dynamics tag for a joint is ignored. The motivation for that is that the friction model in the URDF spec is just one model that I didn't want to get tied down to.

I've used the following code in the past to parse damping values from the URDF after creating a Mechanism (by parsing the same URDF).

https://github.com/tkoolen/QPWalkingControl.jl/blob/master/src/damping.jl

The resulting JointDamping object is callable, and can be used as the control! function with RigidBodySim (possibly combined with other controllers using a SumController). See the cell with comment # create ODEProblem in https://github.com/tkoolen/QPWalkingControl.jl/blob/master/notebooks/Atlas%20walking.ipynb. If you don't want to use RigidBodySim.jl, you can can use the same JointDamping callable object with RigidBodyDynamics.simulate.

I wouldn't actually add a dependency on QPWalkingControl to get this functionality; just copy the file to your own project for now. I think I'll move it to RigidBodyDynamics at some point.

@Islam0mar
Copy link

Thanks, I will try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants