Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid post-computation in Krylov solver #95

Open
tmigot opened this issue Mar 31, 2022 · 0 comments
Open

Avoid post-computation in Krylov solver #95

tmigot opened this issue Mar 31, 2022 · 0 comments

Comments

@tmigot
Copy link
Member

tmigot commented Mar 31, 2022

In

DCISolver.jl/src/dci_feasibility.jl

Line 311 in d45e79f

Jd .= Jz * d #lsmr doesn't return this information

We are computing J * d, while I am suspecting this could be provided by Krylov's method.
Additionally, we are also computing the norm of Jd and d afterwards

DCISolver.jl/src/dci_feasibility.jl

Line 76 in d45e79f

Pred = T(0.5) * (normcz^2 - norm(Jd)^2) # T(0.5) * (normcz^2 - norm(Jd + cz)^2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmigot