Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for julia-v1.7.0 #532

Closed
dmbates opened this issue Jun 8, 2021 · 3 comments · Fixed by #547
Closed

Adjustments for julia-v1.7.0 #532

dmbates opened this issue Jun 8, 2021 · 3 comments · Fixed by #547

Comments

@dmbates
Copy link
Collaborator

dmbates commented Jun 8, 2021

When the workaround for JuliaLang/julia#40048 is merged we can start testing on julia-v1.7.0-DEV

In test/runtests.jl we should replace the call to determine the BLAS in use with BLAS.get_config() for v1.7.0-DEV

A couple of instances of qr(x, Val(true)) need to be replaced by qr(x, ColumnNorm()) for recent versions of v1.7.0-DEV.

@palday
Copy link
Member

palday commented Jun 9, 2021

I had already started tinkering with this locally. 😄 I'll take care of it.

If 1.6 really does become the next LTS, then we should support it until we absolutely need some killer feature from a point release, but I think we can start wrapping some of the incremental improvement and the like in@static to make it really obvious what we can cut when we drop support for 1.6.

On a related note: should we drop all pre 1.6 support with the 4.0 release?

@dmbates
Copy link
Collaborator Author

dmbates commented Jun 9, 2021

Thanks for volunteering.

I feel that we should drop all pre 1.6 support if and when it becomes the LTS release.

@palday
Copy link
Member

palday commented Jun 9, 2021

(Please let that come to pass and soon .... or maybe 1.7 as an LTS, so that we get the BLAS improvements....)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants