Added opt. fname argument to sparseL and condVar #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 94.44% 96.13% +1.68%
==========================================
Files 27 27
Lines 2468 2485 +17
==========================================
+ Hits 2331 2389 +58
+ Misses 137 96 -41
Continue to review full report at Codecov.
|
palday
reviewed
Jul 27, 2021
palday
reviewed
Jul 27, 2021
palday
reviewed
Jul 27, 2021
dmbates
commented
Aug 24, 2021
| @@ -358,7 +350,7 @@ function condVartables(m::MixedModel{T}) where {T} | |||
| return NamedTuple{fnames(m)}((map(_cvtbl, condVar(m), m.reterms)...,)) | |||
| end | |||
|
|
|||
| function pushALblock!(A, L, blk) | |||
| function _pushALblock!(A, L, blk) | |||
There was a problem hiding this comment.
I changed the name of this function to indicate that it was an internal utility.
Co-authored-by: Phillip Alday <[email protected]>
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sparseLgains an optionalfnameargument. When a grouping factor name is given for this argument the return value consists of the lower-right triangle starting at that the rows and columns for that factor.condVargains a method with a second argumentfname. When given the conditional variance array for that factor only is returned.condVarnow just iterates over the grouping factor names.(The old code is retained for comparison but will never be executed - it should be removed after review of this PR.)condVaris inMixedModelsMakie.caterpillarwhich can now be simplified somewhat.