Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loosen type restriction on filename for optsum serialization and rename arg #628

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

palday
Copy link
Member

@palday palday commented Jul 27, 2022

The loosening of the type restriction on the filename-based methods for saveoptsum and restoreoptsum! means that users can pass anytype for which open is defined, e.g. <:AbstractPath.

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@palday palday requested a review from ararslan July 27, 2022 19:55
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #628 (71593e6) into main (3c192f5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 71593e6 differs from pull request most recent head 770c3d0. Consider uploading reports for the commit 770c3d0 to get more accurate results

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          29       29           
  Lines        2765     2765           
=======================================
  Hits         2605     2605           
  Misses        160      160           
Impacted Files Coverage Δ
src/serialization.jl 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c192f5...770c3d0. Read the comment docs.

@palday palday merged commit 73ad7f1 into main Jul 28, 2022
@palday palday deleted the pa/optsumpath branch July 28, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants