-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow predicting from a single observation #653
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportBase: 94.23% // Head: 94.23% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
=======================================
Coverage 94.23% 94.23%
=======================================
Files 29 29
Lines 2795 2795
=======================================
Hits 2634 2634
Misses 161 161
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that the Grouping struct itself doesn't keep track of the levels, I think all the validation stuff can just be skipped altogether. also, would it break anything to just remove the termnames/contrasts_matrix methods altogether? I think the only place they get used is in these constructors...
Co-authored-by: Dave Kleinschmidt <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love 2 delete code.
src/grouping.jl
Outdated
StatsModels.contrasts_matrix(::Grouping, baseind, n) = zeros(0, 0) | ||
StatsModels.termnames(::Grouping, levels::AbstractVector, baseind::Integer) = levels | ||
# StatsModels.contrasts_matrix(::Grouping, baseind, n) = error("Grouping terms don't have associated contrasts") | ||
# StatsModels.termnames(::Grouping, levels::AbstractVector, baseind::Integer) = levels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably better to just clean up this cruft, OR leave the methods as they were before with a note that they're probably not needed since we've added a direct constructor for ContrastsMatrix
Co-authored-by: Dave Kleinschmidt <[email protected]>
closes #625
docs/NEWS-update.jl
to update the cross-references.