Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mulithreading in bootstrap #674

Merged
merged 8 commits into from
Apr 11, 2023
Merged

Deprecate mulithreading in bootstrap #674

merged 8 commits into from
Apr 11, 2023

Conversation

palday
Copy link
Member

@palday palday commented Apr 10, 2023

closes #640

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

src/bootstrap.jl Outdated Show resolved Hide resolved
palday and others added 4 commits April 10, 2023 16:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39 ⚠️

Comparison is base (c68bb4b) 96.28% compared to head (18cded1) 95.89%.

❗ Current head 18cded1 differs from pull request most recent head 4dfd153. Consider uploading reports for the commit 4dfd153 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   96.28%   95.89%   -0.39%     
==========================================
  Files          29       29              
  Lines        2747     2731      -16     
==========================================
- Hits         2645     2619      -26     
- Misses        102      112      +10     
Impacted Files Coverage Δ
src/bootstrap.jl 91.78% <100.00%> (-7.60%) ⬇️
src/utilities.jl 96.92% <100.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palday palday requested a review from dmbates April 11, 2023 15:59
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the name of the function needs to be changed in a @depwarn call in src/utilities.jl. Otherwise looks good to go. Thanks for doing this.

src/utilities.jl Outdated Show resolved Hide resolved
@palday palday merged commit e5d8a6a into main Apr 11, 2023
@palday palday deleted the pa/nothreads branch April 11, 2023 21:17
# no macro version yet: https://github.com/timholy/ProgressMeter.jl/issues/143
use_threads && Base.depwarn(
"use_threads is deprecated and will be removed in a future release",
:replicate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:replicate,
:replicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in threaded_replicate test
2 participants