Fixed minor bug in src/build_function where the keyword conv was not used #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test? |
|
Honnestly, I am not sure what a test could be. As far as I understand, the only supported function to convert expressions as of now is to_expr, so I am not sure why the keyword is included. But the fact is that the keyword was included but was not being used... I am happy to drop the PR, it was a very minor bug. There |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a very minor bug:
The function
build_functionaccepts the keywordconvto perform the conversion function of symbolic types to Expr. However, this was never implemented andtoexprwas "hard-wired". This PR fixes this.