Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs and docstring for Sentiment Analysis model needs fixing #182

Closed
Ayushk4 opened this issue Jan 10, 2020 · 2 comments
Closed

Docs and docstring for Sentiment Analysis model needs fixing #182

Ayushk4 opened this issue Jan 10, 2020 · 2 comments
Labels
good-first-issue help wanted good for beginners

Comments

@Ayushk4
Copy link
Member

Ayushk4 commented Jan 10, 2020

The sentiment model docs and docstrings need minor fixing

julia> model = SentimentAnalyser()
julia> model(doc) or julia> model(doc, handle_unknown)

Thanks to @fungktt for pointing this out in slack.
@kimttfung
Copy link

Thanks! @Ayushk4

@tejasvaidhyadev tejasvaidhyadev mentioned this issue Jan 10, 2020
Merged
@kimttfung kimttfung mentioned this issue Jan 15, 2020
Open
@Ayushk4
Copy link
Member Author

Ayushk4 commented Jan 15, 2020

Fixed in #184 .

@Ayushk4 Ayushk4 closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue help wanted good for beginners
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimttfung @Ayushk4